[libsnoretoast] fix absolute include paths by wrobelda · Pull Request #20229 · microsoft/vcpkg

wrobelda · 2021-09-17T12:36:02Z

Describe the pull request
Fixes issues with LibSnoreToast usage on Windows. See: #19828 (comment)

Which triplets are supported/not supported? Have you updated the CI baseline?

No change.
Does your PR follow the maintainer guide?

Yes.
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libsnoretoast but no changes to version or port version.
-- Version: 0.8.0
-- Old SHA: 7ddd1b84089de293b4a9d74af6b7593d089084a9
-- New SHA: c30fe7a20b36f824198b72117cb13ae5e4eec46b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 69d5556d0d8c105f75055326cef346546e40e615 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libsnoretoast.json b/versions/l-/libsnoretoast.json
index 713dbcb..609c6e7 100644
--- a/versions/l-/libsnoretoast.json
+++ b/versions/l-/libsnoretoast.json
@@ -1,8 +1,8 @@
 {
   "versions": [
     {
-      "git-tree": "c30fe7a20b36f824198b72117cb13ae5e4eec46b",
-      "version": "0.8.0",
+      "git-tree": "7ddd1b84089de293b4a9d74af6b7593d089084a9",
+      "version-semver": "0.8.0",
       "port-version": 0
     }
   ]

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/ffnvcodec/portfile.cmake
ports/libproxy/portfile.cmake
ports/libsnoretoast/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libsnoretoast but no changes to version or port version.
-- Version: 0.8.0
-- Old SHA: 7ddd1b84089de293b4a9d74af6b7593d089084a9
-- New SHA: babb3a1599adf46a6862815fab452d9048920c84
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 69d5556d0d8c105f75055326cef346546e40e615 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libsnoretoast.json b/versions/l-/libsnoretoast.json
index 6c478ba..609c6e7 100644
--- a/versions/l-/libsnoretoast.json
+++ b/versions/l-/libsnoretoast.json
@@ -1,8 +1,8 @@
 {
   "versions": [
     {
-      "git-tree": "babb3a1599adf46a6862815fab452d9048920c84",
-      "version": "0.8.0",
+      "git-tree": "7ddd1b84089de293b4a9d74af6b7593d089084a9",
+      "version-semver": "0.8.0",
       "port-version": 0
     }
   ]

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/ffnvcodec/portfile.cmake
ports/libproxy/portfile.cmake
ports/libsnoretoast/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 69d5556d0d8c105f75055326cef346546e40e615 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libsnoretoast.json b/versions/l-/libsnoretoast.json
index 53233ef..513047f 100644
--- a/versions/l-/libsnoretoast.json
+++ b/versions/l-/libsnoretoast.json
@@ -6,8 +6,8 @@
       "port-version": 1
     },
     {
-      "git-tree": "babb3a1599adf46a6862815fab452d9048920c84",
-      "version": "0.8.0",
+      "git-tree": "7ddd1b84089de293b4a9d74af6b7593d089084a9",
+      "version-semver": "0.8.0",
       "port-version": 0
     }
   ]

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/ffnvcodec/portfile.cmake
ports/libproxy/portfile.cmake
ports/libsnoretoast/portfile.cmake

NancyLi1013 · 2021-09-18T02:52:31Z

LGTM, thanks for your fixing.

BillyONeal · 2021-09-20T17:05:46Z

The version database for previous versions was damaged so I fixed it to only add the new port-version.

BillyONeal · 2021-09-20T17:55:45Z

Thanks for the fix :D

wrobelda mentioned this pull request Sep 17, 2021

[kf5notifications] new port #19828

Merged

4 tasks

wrobelda force-pushed the snoretoast_include_fix branch from f727c80 to 9a127b0 Compare September 17, 2021 12:39

github-actions bot requested changes Sep 17, 2021

View reviewed changes

wrobelda added 3 commits September 17, 2021 14:42

[libsnoretoast] fix absolute include paths

c71daa5

[libsnoretoast] fix versioning scheme

8f765d9

[libsnoretoast] update versions

62a504c

wrobelda force-pushed the snoretoast_include_fix branch from 9a127b0 to 62a504c Compare September 17, 2021 12:42

github-actions bot requested changes Sep 17, 2021

View reviewed changes

JonLiu1993 assigned NancyLi1013 Sep 18, 2021

NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label Sep 18, 2021

NancyLi1013 approved these changes Sep 18, 2021

View reviewed changes

NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 18, 2021

BillyONeal added 2 commits September 20, 2021 10:02

Merge remote-tracking branch 'origin/master' into HEAD

8854c2c

Fix damage to previous version in the version database.

0ef2779

github-actions bot approved these changes Sep 20, 2021

View reviewed changes

BillyONeal merged commit 36fe652 into microsoft:master Sep 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[libsnoretoast] fix absolute include paths#20229

[libsnoretoast] fix absolute include paths#20229
BillyONeal merged 5 commits intomicrosoft:masterfrom
wrobelda:snoretoast_include_fix

wrobelda commented Sep 17, 2021 •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

NancyLi1013 commented Sep 18, 2021

Uh oh!

BillyONeal commented Sep 20, 2021

Uh oh!

BillyONeal commented Sep 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

wrobelda commented Sep 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

NancyLi1013 commented Sep 18, 2021

Uh oh!

BillyONeal commented Sep 20, 2021

Uh oh!

BillyONeal commented Sep 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wrobelda commented Sep 17, 2021 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?